Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Typo Update README.md #910

Closed
wants to merge 3 commits into from
Closed

Conversation

harshpoddar03
Copy link

Replaced Principal with Candid, typo in readme

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

Replaced Principal with Candid, typo in readme
@harshpoddar03 harshpoddar03 requested a review from a team as a code owner July 29, 2024 08:37
@ghost ghost changed the title Bug Fix: Typo Update README.md chore: Typo Update README.md Oct 23, 2024
@sa-github-api
Copy link

Dear @harshpoddar03,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.

If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.

— The DFINITY Foundation

@ghost
Copy link

ghost commented Oct 23, 2024

Hello @harshpoddar03. Thank you for your contribution. Can you please accept the CLA if you'd like this PR to get merged in? Thank you

@ghost ghost mentioned this pull request Oct 24, 2024
@ghost
Copy link

ghost commented Oct 24, 2024

We'll merge this in #947

@ghost ghost closed this Oct 24, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants